Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J/K keyboard hotkey doesn't properly scroll when a tweet is selected #568

Closed
shny-scott opened this issue Aug 6, 2023 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@shny-scott
Copy link

shny-scott commented Aug 6, 2023

Please check the following before you continue

  • [Typescript beta, but it happens on the JS version too] Bug happens with the newest version of GT2 (see the changelog)
  • [Yep] Checked FAQ
  • [As far as I can tell] Checked if the issue has not been reported before

Describe the bug
A clear and concise description of what the bug is.
What sites does it affect?
The J and K keyboard shortcuts are supposed to select the next and previous tweet on screen respectively. They still do this with GT2, but it doesn't work when you click on a tweet (possibly due to the "Tweet" heading bar with the back arrow). It does work properly on the main timeline and profile pages, although it acts differently on both - on profile pages the tweet snaps all the way to the top, while on the timeline there's a gap between the top and the highlighted tweet.
Stock Twitter behavior is to snap the tweet as high as it can go while making sure that heading bars such as the "Tweet" bar or the timeline's "For You/Following" bar do not cover it.

Screenshots
For display issues, adding screenshots or even videos of your screen is recommended.
Scrolling down to a reply with only one line of text:
image
Attempting to scroll all the way up to the main tweet with K does not go all the way (art by onebadnoodle_):
image

Stock Twitter for reference - the image is snapped as high as possible and not covered:
image

Your configuration

  • Browser - Firefox 116
  • Userscript Manager - Tampermonkey 4.19
@shny-scott shny-scott added the bug Something isn't working label Aug 6, 2023
@Bl4Cc4t
Copy link
Owner

Bl4Cc4t commented Aug 10, 2023

Hm, I never used the shortcuts before. Should hopefully be easy to fix

@Bl4Cc4t
Copy link
Owner

Bl4Cc4t commented Feb 22, 2024

Sorry for the long absence (again)

I just fixed this today.
see v1.0.0-beta.3 for latest beta!

@Bl4Cc4t Bl4Cc4t closed this as completed Feb 22, 2024
@shny-scott
Copy link
Author

While it does work fine on the main timeline (alignment slightly off but I'm okay with that), it unfortunately still doesn't work in the replies to other tweets.
image

@shny-scott
Copy link
Author

never mind I clicked the readme install link to update and didn't realize it was still the old pre-typescript version, actually installing the right version works fine. sorry about that

@Bl4Cc4t
Copy link
Owner

Bl4Cc4t commented Mar 10, 2024

Great to hear it works! Hopefully the new version will get more stable soon so I can replace some links to make it less confusing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants