-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
J/K keyboard hotkey doesn't properly scroll when a tweet is selected #568
Comments
Hm, I never used the shortcuts before. Should hopefully be easy to fix |
Sorry for the long absence (again) I just fixed this today. |
never mind I clicked the readme install link to update and didn't realize it was still the old pre-typescript version, actually installing the right version works fine. sorry about that |
Great to hear it works! Hopefully the new version will get more stable soon so I can replace some links to make it less confusing :D |
Please check the following before you continue
Describe the bug
A clear and concise description of what the bug is.
What sites does it affect?
The J and K keyboard shortcuts are supposed to select the next and previous tweet on screen respectively. They still do this with GT2, but it doesn't work when you click on a tweet (possibly due to the "Tweet" heading bar with the back arrow). It does work properly on the main timeline and profile pages, although it acts differently on both - on profile pages the tweet snaps all the way to the top, while on the timeline there's a gap between the top and the highlighted tweet.
Stock Twitter behavior is to snap the tweet as high as it can go while making sure that heading bars such as the "Tweet" bar or the timeline's "For You/Following" bar do not cover it.
Screenshots
For display issues, adding screenshots or even videos of your screen is recommended.
Scrolling down to a reply with only one line of text:
Attempting to scroll all the way up to the main tweet with K does not go all the way (art by onebadnoodle_):
Stock Twitter for reference - the image is snapped as high as possible and not covered:
Your configuration
The text was updated successfully, but these errors were encountered: