Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests optional dependency #325

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

manulera
Copy link
Collaborator

@manulera manulera commented Nov 7, 2024

No description provided.

@manulera manulera changed the base branch from master to dev_bjorn November 7, 2024 11:08
@manulera
Copy link
Collaborator Author

manulera commented Nov 7, 2024

This fails because I changed the target of the PR after having created it, but tests pass, merging.

@manulera manulera merged commit 96df3f1 into dev_bjorn Nov 7, 2024
34 of 35 checks passed
@manulera manulera deleted the requests_optional_dependency branch November 7, 2024 11:18
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (3ab5c7c) to head (28f7531).
Report is 2 commits behind head on dev_bjorn.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           dev_bjorn     #325   +/-   ##
==========================================
  Coverage      93.63%   93.63%           
==========================================
  Files             40       40           
  Lines           3926     3926           
  Branches         589      589           
==========================================
  Hits            3676     3676           
  Misses           198      198           
  Partials          52       52           
Files with missing lines Coverage Δ
src/pydna/tm.py 96.92% <100.00%> (ø)

manulera added a commit that referenced this pull request Nov 10, 2024
* fix icon link

* closes #279 again (for circular seqs) (#324)

* move requests optional dependency into function body (#325)

* closes #262 (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant