Add some basic type hints #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawinsw
force-pushed
the
issue_176_basic
branch
from
d0e87f6
to
832331c
Compare
kawinsw
force-pushed
the
issue_176_basic
branch
from
832331c
to
d5528aa
Compare
BjornFJohansson
merged commit 8179b76
into
BjornFJohansson:dev_bjorn
15 of 16 checks passed
|
Hi @kawinsw thank you so much for this contribution. I went through it, and it all looks great. This is really valuable, specially for newcomers but also for us. I often find myself adding in-line type hints in my scripts to get intellisense when using pydna, so it's very appreciated. Cheers, |
|
Glad this helps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic work on issue #176 for the following:
PrettyTablecodonSeqFakeSeqGenbanksequence_pickercommon_sub_stringsAssemblyNew to this project, so let me know if I've misinterpreted anything or there are some conventions I should follow.