Fixed UserOp Identifier #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifrel
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Why are some test files called .spec.ts and others .test.ts?
There was a problem hiding this comment.
Ahh whoops. They are both common. I just forgot to only use one.
tifrel
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
I see a few console.logs in here, but I am not the biggest fan of those in library functions. I know near-api-js does it and it drives me nuts. We might want to consider guarding them behind an environment variable, e.g. if NEAR_SAFE_LOGS=1 or so. Out of scope for this PR though.
|
Ya, it would be good to introduce a proper logger so those logs can be disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Safe Salt Nonce is one way to identify Bitte Protocol Safes, but requires querying traces:
The Query Execution by SafeSaltNonce is computationally expensive and slow:
https://dune.com/queries/4150748 (9 minutes on large cluster)
However, appending an Identifier to the call data bytes reduces the complexity substantially:
https://dune.com/queries/4151053 (1 minute on large cluster)
This PR Proposes using both.
Observe that the SafeSaltNonce is left configurable to end users but the UserOpIdentifier will be permanently baked into the call data of every outgoing transaction from this library.