Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Transaction Decoding #107

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Improved Transaction Decoding #107

merged 4 commits into from
Nov 14, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented Nov 12, 2024

Most of the heavy lifting was introduced in the direct dependency (BitteProtocol/near-ca#146).
Here we use that to improve our transaction decoding functionality:

  • Add Type Guard for UserOperation
  • Inherit Type Guards from near-ca
  • improve decodeTx function safety
  • Unit test isUserOperation
  • Ensure the logged Warning disappears in existing test (adapter: encodeEvmTx)

@bh2smith bh2smith marked this pull request as ready for review November 14, 2024 06:42
@bh2smith bh2smith merged commit 3bfeaef into main Nov 14, 2024
1 check passed
@bh2smith bh2smith deleted the 100/type-guards branch November 14, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant