Add code coverage #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
May 24, 2024
| @@ -18,6 +19,7 @@ const SUPPORTED_NETWORKS = createNetworkMap([ | |||
| arbitrum, | |||
| optimism, | |||
| optimismSepolia, | |||
| localhost, | |||
There was a problem hiding this comment.
This is interesting... so we can use it with ganache now?
|
Beauty! We will wait till the end of the weekend to merge things. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage is a very important part of keeping a code base up to standard and it enhances its long term maintenance, reducing bugs.
In this PR I would like to add coverage to the project and I also increase the code coverage to over 80%.