Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Preparing for WC Integration #35

Merged
merged 2 commits into from
May 8, 2024
Merged

Refactor: Preparing for WC Integration #35

merged 2 commits into from
May 8, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented May 8, 2024

While working on #34, I noticed some redundancies, inconsistencies and non-necessities in the existing code. Realistically we should rework the design of this package (while its still pre-v1).

  • lint configuration was cleaned up by prettier (also adding indentation to switch cases).
  • ignore lint config file going forward.
  • populate transaction method removing complexity from adapter (Will also be used by WC Router).
  • pickValidSignature did not need to be part of the adapter class.
  • MPCContract.encodeSignatureRequestTx didn't need to be async.
  • Adding optional gas limit to BaseTx (since it is provided by WC session request payload). When included we can skip an rpc call.
  • documentation type (De)serializedTx
  • Introducing a method toPayload that builds number array of bytes for MPC contract.

@bh2smith bh2smith requested a review from tifrel May 8, 2024 12:52
@bh2smith bh2smith merged commit 0b1a6a0 into main May 8, 2024
1 check passed
@bh2smith bh2smith deleted the quick-refactor branch May 8, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant