New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Type Interface #20

Merged

bh2smith merged 3 commits into main from better-types

Apr 9, 2024

Collaborator

bh2smith commented Apr 9, 2024

Fix dated example script imports
Improve BaseTx type interface
Expose more public methods on adapter
Use optional nonce field on tx builders (this was added mostly for deterministic testing).
Add createTxPayload unit test.

I was a bit surprised to see that the gas estimates did not affect the tx payload... don't users have to sign their gas limits?

bh2smith added 3 commits

April 9, 2024 16:22


          improve types and make some functions public

312f708


          add createTx test

64c5c2a


          cant test this without exposing PK

3bb43aa

bh2smith changed the title ~~Better types~~ Improve Type Interface

bh2smith merged commit 464a1e9 into main

1 check passed

bh2smith deleted the better-types branch

April 9, 2024 21:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet