Improved Common Lib Unit Test Readability #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The objective of this change is to improve the readability of the common lib module unit test, which is necessary for effective testing, given that a peculiar function
extractPubKey
in the common lib is quite crucial for the correctness of the Project,Problem
The common lib module is not utilising behavioural test patterns which makes isolating a specific branch of the code under test quite difficult. The problem is quite critical for functions with extreme number of branch paths such as
extractPubKey
.Changes
Scope Of Change
This is a non critical change because it only affects a unit test file.