-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecash section to guide #1093
Conversation
Introducing an ecash folder into the guide. This branch will be the working draft.
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Removed old illustration. Added notes for future illustrations.
Added overview, cashu, and introduction page.
…ration illustrations, updated design best practices page to include user onboarding, mint connection, and mint discovery.
…e alt text and captions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tons of progress since I last reviewed. It's looking really great.
There's some more minor formal stuff that I noticed that should be tweaked, such as:
- Removing the unused
images_backup
incashu.md
- Making title capitalization consistent to sentence case (pages use a mix right now, sentence case is guide standard)
- Remove link to Mutiny Wallet, since that product is being shut down
improveme
typo at the top of the design practices page- Next link on design practices page would go to private key management
- Don't define
mobile
andmobileRetina
images if it's just the same as the non-retina image - Page titles, editor's notes and next sentences at the bottom state that the pages are an
introduction
,a detailed summary
, and atechnical deep-dive
. Need to pick one. recieves
typo and duplicate image captions in the design practices page
I did not try to make a comprehensive list, so there's probably some more. But I think all this can be easily done in a follow-up PR.
The one thing that I think should be done before merging this one is to compress all the images (using ImageOptim, for example). You can reduce them by ~60%. That will help a lot with page load times. Doing that pre-merge keeps our repo history a little cleaner.
After that, maybe also resolve the ~30 unresolved conversations, and set up a follow-up PR for some of the fine-grained stuff. Let's get this thing out the door.
Congrats, sorry, and thanks for dealing with almost 350 comments on this PR. It's a beast.
I also went back and made updates to the comments you left in September. I made the updates, left a comment, and resolved the comments. I also ran all the images through ImageOptim. That made a huge difference. Saved a total of 6.2 MB. Thanks for sharing this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handful of minor tweaks still. Then let's go.
Co-authored-by: Christoph Ono <[email protected]>
Apply suggestions from GBKS Co-authored-by: Christoph Ono <[email protected]>
…d introduciton.md
… and fedimint.md. Added Fedimint Web SDK as to resource list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Let's go!
ACK. Let's merge! |
Hey @GBKS @mouxdesign @danielnordh.
I am working on the ecash section for the design guide. I have some foundations laid down and would like to submit a Draft PR so I can preview it in a test environment.
I would like to keep pushing changes to the draft PR regularly as I will be adding illustrations, updating copy, moving things around etc...
I'm still rather new to this process so please let me know what are the best practices here.
Preview