Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional ui epics and clan comp. #1636

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Additional ui epics and clan comp. #1636

merged 1 commit into from
Jan 10, 2024

Conversation

tchalvak
Copy link
Member

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

Copy link

cypress bot commented Jan 10, 2024

2 failed tests on run #165 ↗︎

2 6 0 0 Flakiness 0

Details:

Merge cf22643 into bbf5af5...
Project: NinjaWars Functional Testing Commit: 4e1ddbd7d7 ℹ️
Status: Failed Duration: 01:30 💡
Started: Jan 10, 2024 2:12 AM Ended: Jan 10, 2024 2:13 AM
Failed  cypress/e2e/signup.cy.js • 2 failed tests

View Output

Test Artifacts
signup a new ninja > rejects signup for configured user, as should already exist Test Replay Screenshots
signup a new ninja > allows signup for a randomized ninja Test Replay Screenshots

Review all test suite changes for PR #1636 ↗︎

@tchalvak tchalvak merged commit aee344a into master Jan 10, 2024
13 of 16 checks passed
@tchalvak tchalvak deleted the feat/analytics branch January 10, 2024 02:25
Copy link

cypress bot commented Jan 10, 2024

2 failed tests on run #166 ↗︎

2 6 0 0 Flakiness 0

Details:

Merge pull request #1636 from BitLucid/feat/analytics
Project: NinjaWars Functional Testing Commit: aee344a2c4
Status: Failed Duration: 01:36 💡
Started: Jan 10, 2024 2:25 AM Ended: Jan 10, 2024 2:27 AM
Failed  cypress/e2e/signup.cy.js • 2 failed tests

View Output

Test Artifacts
signup a new ninja > rejects signup for configured user, as should already exist Test Replay Screenshots
signup a new ninja > allows signup for a randomized ninja Test Replay Screenshots

Review all test suite changes for PR #1636 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant