Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump solana/web3 library #2718

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

joey-bai
Copy link
Contributor

@joey-bai joey-bai commented Sep 1, 2022

updates solana/web3 library to match what spl-token is using.

Ticket: BG-56444

Notes
This was causing errors when updating dependences in lumina.
Suggested fix (solana-labs/solana-program-library#2683) is to ensure the @solana/buffer-layout library version is ^4.0.0, which is available in recent versions of sol/web3.

runtime.js:39 Uncaught TypeError: fields must be array of Layout instances
    at new Structure (Layout.js?3cb5:999:1)
    at exports.struct (Layout.js?3cb5:2373:1)
    at eval (multisig.js?5689:18:1)
    at ../client-dashboard-shared/node_modules/@solana/spl-token/lib/cjs/state/multisig.js (npm.solana.js:1018:1)
    at __webpack_require__ (runtime.js:36:33)
    at fn (runtime.js:423:21)
    at eval (account.js?7c6a:17:1)
    at ../client-dashboard-shared/node_modules/@solana/spl-token/lib/cjs/state/account.js (npm.solana.js:988:1)
    at __webpack_require__ (runtime.js:36:33)
    at fn (runtime.js:423:21)
    at eval (extensionType.js?8190:4:1)
    at ../client-dashboard-shared/node_modules/@solana/spl-token/lib/cjs/extensions/extensionType.js (npm.solana.js:498:1)
    at __webpack_require__ (runtime.js:36:33)
    at fn (runtime.js:423:21)
    at eval (state.js?c2fa:5:1)
    at ../client-dashboard-shared/node_modules/@solana/spl-token/lib/cjs/extensions/defaultAccountState/state.js (npm.solana.js:488:1)
    at __webpack_require__ (runtime.js:36:33)
    at fn (runtime.js:423:21)
    at eval (index.js?b35d:15:1)
    at ../client-dashboard-shared/node_modules/@solana/spl-token/lib/cjs/extensions/defaultAccountState/index.js (npm.solana.js:468:1)
    at __webpack_require__ (runtime.js:36:33)
    at fn (runtime.js:423:21)

Additionally, there were changes to serialization logic in version version 1.32.0, which required us to update a bunch of test fixtures.

updates solana/web3 library to match what spl-token is using.

Ticket: BG-56444

fix
@joey-bai joey-bai force-pushed the BG-56444-bump-sol-library branch from 18275ac to 01238b7 Compare September 1, 2022 03:10
@joey-bai joey-bai marked this pull request as ready for review September 1, 2022 03:32
@mmcshinsky-bitgo mmcshinsky-bitgo merged commit 3ecf30d into master Sep 1, 2022
@ericcrosson-bitgo ericcrosson-bitgo deleted the BG-56444-bump-sol-library branch September 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants