Add Travis CI with Dockerfile #34
Conversation
Dockerfile
Outdated
| RUN mkdir -p /opt/go_dist &&\ | ||
| curl https://dl.google.com/go/go1.11.linux-amd64.tar.gz | tar -xz -C /opt/go_dist | ||
|
|
||
| ENV GOPATH /opt/go |
Dockerfile
Outdated
| gcc \ | ||
| libc6-dev \ | ||
| make \ | ||
| curl \ |
There was a problem hiding this comment.
I tested at 22ba5ee, and there's a typo in travis-ci.sh.
Otherwise, the change seems to work as expected. As described, the make -C <...>/middleware ci fails until the Go code adheres to the .golangci config.
Should we merge those improvements before this PR, in your opinion?
And how should we line up this PR with #31, which also changes quite a lot of details? Merge #31 first, then any necessary patches to address style, then the current one?
Okay. Typically I prefer keeping the builds passing with each patchset, but since we haven't had any CI at all before this change I guess this method works, as long as we revisit and address the issues in |
Travis CI now runs builds of the middleware and the bbbfancontrol. The travis job runs in its own docker container and runs golangci-lint according the specs defined in middleware/.golangci.yml .
Travis CI now runs builds of the middleware and the bbbfancontrol. The travis job runs in its own docker container and runs golangci-lint according the specs defined in middleware/.golangci.yml .
I split the actual docker run into a separate file. When I ran the same lines directly from the script part of the travis.yml , the travis build would fail with the error: "docker: invalid reference format". Tips on how to fix this are welcome.
The travis build will initially fail until the middleware sticks to the golangci style.