Merge pull request #140 from BitBagCommerce/OPSRC-583/Import_wishlist…

…_from_csv remove exception if a product from the csv file doesn't exist
BitBagCommerce · Jul 1, 2022 · 07b04e9 · 07b04e9
2 parents d33d865 + 96ada78
commit 07b04e9
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/CommandHandler/Wishlist/ImportWishlistFromCsvHandler.php b/src/CommandHandler/Wishlist/ImportWishlistFromCsvHandler.php
@@ -72,12 +72,11 @@ private function getDataFromFile(\SplFileInfo $fileInfo, Request $request): void
 
         /** @var CsvWishlistProduct $csvWishlistProduct */
         foreach ($csvWishlistProducts as $csvWishlistProduct) {
-            if (!$this->csvWishlistProductIsValid($csvWishlistProduct)) {
-                return;
+            if ($this->csvWishlistProductIsValid($csvWishlistProduct)) {
+                $variantIdRequestAttributes[] = $csvWishlistProduct->getVariantId();
+                $request->attributes->set('variantId', $variantIdRequestAttributes);
             }
-            $variantIdRequestAttributes[] = $csvWishlistProduct->getVariantId();
         }
-        $request->attributes->set('variantId', $variantIdRequestAttributes);
     }
 
     private function fileIsValidMimeType(\SplFileInfo $fileInfo): bool
@@ -96,7 +95,7 @@ private function csvWishlistProductIsValid(CsvWishlistProductInterface $csvWishl
         ]);
 
         if (null === $wishlistProduct) {
-            throw new NotFoundHttpException();
+            return false;
         }
 
         return true;