Python: add ZDIFF command #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
force-pushed
the
python/dev_acongo_zdiff
branch
from
6d8c989
to
5b3f77b
Compare
Yury-Fridlyand
requested review from
GumpacG,
jonathanl-bq,
acarbonetto,
tjzhang-BQ and
jhmannok
Yury-Fridlyand
approved these changes
May 2, 2024
| keys (List[str]): The keys of the sorted sets. | ||
|
|
||
| Returns: | ||
| Dict[str, float]: A dictionary of elements and their scores representing the difference between the sorted |
There was a problem hiding this comment.
I wasn't aware of the Mapping type but apparently it is a more general type than Dict. Its unclear which one is better, the existing code uses both somewhat interchangeably. According to this SO post Dict is preferred for return types and Mapping for arguments, but the existing code has both types in both places
|
Maybe you need to rebase your branches to let CI pass |
GumpacG
approved these changes
May 2, 2024
aaron-congo
force-pushed
the
python/dev_acongo_zdiff
branch
from
dcb022e
to
11c52fe
Compare
aaron-congo
added a commit
that referenced
this pull request
May 13, 2024
tjzhang-BQ
pushed a commit
that referenced
this pull request
May 13, 2024
* Python: add ZDIFF command (#255) * Add PR link in CHANGELOG * PR suggestions
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Python: add ZDIFF command (#255) * Add PR link in CHANGELOG * PR suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/docs/latest/commands/zdiff/
Note: depends on update to cluster_routing.rs in redis-rs