Fixes "ResultSet.getTime() returns null" bug
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
margarit-h
changed the title
ResultSet.getTime() returns null bugResultSet.getTime() returns null' bug
margarit-h
changed the title
ResultSet.getTime() returns null' bugResultSet.getTime() returns null" bug
Signed-off-by: Margarit Hakobyan <[email protected]>
GumpacG
reviewed
Dec 27, 2022
| if (value instanceof Time) { | ||
| return asTime((Time) value); | ||
| return (Time) value; |
There was a problem hiding this comment.
Should the returned value here be converted to localtime similar to the case where value is a string?
There was a problem hiding this comment.
I don't see what adding that extra step will accomplish in this case, so I return value as java.sql.Time when the value is of type java.sql.Time. In case of string, value needs to be checked and converted correctly, so LocalTime is used to do so.
GumpacG
approved these changes
Dec 27, 2022
acarbonetto
reviewed
Dec 30, 2022
| cal == null ? "null" : "Calendar TZ= " + cal.getTimeZone())); | ||
| checkCursorOperationPossible(); | ||
| Time value = getTimeX(columnIndex, cal); | ||
| log.debug(() -> logExit("getTime", value)); |
There was a problem hiding this comment.
acarbonetto
approved these changes
Dec 30, 2022
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Jan 11, 2023
…ject#41) * Fixes ResultSet.getTime returns null bug Signed-off-by: Margarit Hakobyan <[email protected]> Signed-off-by: Margarit Hakobyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Margarit Hakobyan [email protected]
Description
ResultSet.getTime()returns non-null value reflecting the retrieved time instead ofnull.Issues Resolved
opensearch-project#20
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.