-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzer and operator parameters to match_bool_prefix #72
Add analyzer and operator parameters to match_bool_prefix #72
Conversation
Signed-off-by: MaxKsyunz <[email protected]>
Is it worth testing the function with all parameters in |
Codecov Report
@@ Coverage Diff @@
## integ-match_bool_prefix-#187 #72 +/- ##
===============================================================
Coverage 97.67% 97.67%
- Complexity 2754 2756 +2
===============================================================
Files 269 269
Lines 6789 6791 +2
Branches 435 435
===============================================================
+ Hits 6631 6633 +2
Misses 157 157
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...ava/org/opensearch/sql/opensearch/storage/script/filter/lucene/MatchBoolPrefixQueryTest.java
Show resolved
Hide resolved
Please, update docs too. |
Mention analyzer and operator optional parameters. Signed-off-by: MaxKsyunz <[email protected]>
Yes, I think so. I would like to do that in separate PRs -- one for |
Along with plugin jars, plugin zips should also be published to maven repo with right maven coordinates, so user can download these plugins using dependancy model. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Description
These were flagged as missing in the upstream PR opensearch-project#634.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.