Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer and operator parameters to match_bool_prefix #72

Merged

Conversation

MaxKsyunz
Copy link

@MaxKsyunz MaxKsyunz commented Jun 16, 2022

Description

These were flagged as missing in the upstream PR opensearch-project#634.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MaxKsyunz MaxKsyunz requested a review from a team June 16, 2022 00:51
@MaxKsyunz MaxKsyunz assigned MaxKsyunz and unassigned MaxKsyunz Jun 16, 2022
@Yury-Fridlyand
Copy link

Yury-Fridlyand commented Jun 16, 2022

Is it worth testing the function with all parameters in FilterQueryBuilderTest.java and in MatchBoolPrefixIT.java?

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #72 (111a8e6) into integ-match_bool_prefix-#187 (9b0eeb9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                       Coverage Diff                       @@
##             integ-match_bool_prefix-#187      #72   +/-   ##
===============================================================
  Coverage                           97.67%   97.67%           
- Complexity                           2754     2756    +2     
===============================================================
  Files                                 269      269           
  Lines                                6789     6791    +2     
  Branches                              435      435           
===============================================================
+ Hits                                 6631     6633    +2     
  Misses                                157      157           
  Partials                                1        1           
Flag Coverage Δ
sql-engine 97.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../filter/lucene/relevance/MatchBoolPrefixQuery.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcc123...111a8e6. Read the comment docs.

@Yury-Fridlyand
Copy link

Please, update docs too.

Mention analyzer and operator optional parameters.

Signed-off-by: MaxKsyunz <[email protected]>
@MaxKsyunz
Copy link
Author

Is it worth testing the function with all parameters in FilterQueryBuilderTest.java and in MatchBoolPrefixIT.java?

Yes, I think so.

I would like to do that in separate PRs -- one for FilterQueryBuilderTest that will add test cases for all other optional parameters for match_bool_prefix, and another PR for MatchBoolPrefixIT after I update from upstream and can use the brewing dataset.

@MaxKsyunz MaxKsyunz merged commit 2d2ddf8 into integ-match_bool_prefix-#187 Jun 17, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-match_bool_prefix-#187-more-params branch January 12, 2023 19:45
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
Along with plugin jars, plugin zips should also be published to
maven repo with right maven coordinates,
so user can download these plugins using dependancy model.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants