Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Using custom Java formatter from k-nn plugin #315

Closed
wants to merge 2 commits into from

Conversation

MitchellGale
Copy link

Description

Applied spotless on core/src/main/java/org/opensearch/sql/{expression, executor, datasource, data, analysis}

Fixes issue with Java doc seen in #312 by applying custom xml to format code instead of Google Java Formatter.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (integ/sl_customFormatter@af12c02). Click here to learn what that means.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##             integ/sl_customFormatter     #315   +/-   ##
===========================================================
  Coverage                            ?   97.29%           
  Complexity                          ?     4572           
===========================================================
  Files                               ?      401           
  Lines                               ?    11180           
  Branches                            ?      810           
===========================================================
  Hits                                ?    10878           
  Misses                              ?      295           
  Partials                            ?        7           
Flag Coverage Δ
sql-engine 97.29% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant