forked from opensearch-project/sql
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Nested Function in Order By Clause #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestmvey
requested review from
MaxKsyunz,
Yury-Fridlyand,
acarbonetto and
GumpacG
as code owners
June 22, 2023 18:32
forestmvey
changed the title
Dev nested order by
Add Support for Nested Function in Order By Clause
Jun 22, 2023
Yury-Fridlyand
approved these changes
Jun 22, 2023
...search/src/main/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilder.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## integ-nested-order-by #280 +/- ##
========================================================
Coverage 97.29% 97.29%
- Complexity 4408 4415 +7
========================================================
Files 388 388
Lines 10944 10960 +16
Branches 774 777 +3
========================================================
+ Hits 10648 10664 +16
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matthewryanwells
approved these changes
Jun 23, 2023
...search/src/main/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilder.java
Show resolved
Hide resolved
...search/src/main/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilder.java
Outdated
Show resolved
Hide resolved
...rch/src/main/java/org/opensearch/sql/opensearch/storage/scan/OpenSearchIndexScanBuilder.java
Show resolved
Hide resolved
MitchellGale
approved these changes
Jun 23, 2023
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
forestmvey
force-pushed
the
dev-nested-order-by
branch
from
June 26, 2023 15:21
eeb254b
to
72043d4
Compare
GumpacG
reviewed
Jun 26, 2023
GumpacG
approved these changes
Jun 26, 2023
forestmvey
added a commit
that referenced
this pull request
Jun 27, 2023
* Adding order by clause support for nested function. Signed-off-by: forestmvey <[email protected]> * Adding test coverage for nested in ORDER BY clause. Signed-off-by: forestmvey <[email protected]> * Added nested function validation to NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]>
acarbonetto
pushed a commit
that referenced
this pull request
Jun 27, 2023
…t#1789) * Add Support for Nested Function in Order By Clause (#280) * Adding order by clause support for nested function. Signed-off-by: forestmvey <[email protected]> * Adding test coverage for nested in ORDER BY clause. Signed-off-by: forestmvey <[email protected]> * Added nested function validation to NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> * Adding semantic check for missing arguments in function and unit test. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]>
MaxKsyunz
pushed a commit
that referenced
this pull request
Jul 7, 2023
…t#1789) (opensearch-project#1794) * Add Support for Nested Function in Order By Clause (#280) * Adding order by clause support for nested function. Signed-off-by: forestmvey <[email protected]> * Adding test coverage for nested in ORDER BY clause. Signed-off-by: forestmvey <[email protected]> * Added nested function validation to NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> * Adding semantic check for missing arguments in function and unit test. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 3302ec8) Co-authored-by: Forest Vey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for nested function use in the
ORDER BY
clause.Example Queries
Issues Resolved
Portion of Issue: 1111
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.