Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest fix for protocol.rst for update of PPL query error message #269

Merged
merged 1 commit into from
May 26, 2023

Conversation

MitchellGale
Copy link

Description

Fixes error in protocol.rst test.

Old:

  "error": {
    "reason": "Error occurred in OpenSearch engine: no such index [unknown]",
    "details": "org.opensearch.index.IndexNotFoundException: no such index [unknown]\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.",
    "type": "IndexNotFoundException"

New:

  "error": {
    "reason": "Error occurred in OpenSearch engine: no such index [unknown]",
    "details": "[unknown] IndexNotFoundException[no such index [unknown]]\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.",
    "type": "IndexNotFoundException"

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #269 (f913f0f) into Integ-fixDocTestProtocol (8e5d766) will not change coverage.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##             Integ-fixDocTestProtocol     #269   +/-   ##
===========================================================
  Coverage                       97.16%   97.16%           
  Complexity                       4120     4120           
===========================================================
  Files                             371      371           
  Lines                           10373    10373           
  Branches                          704      704           
===========================================================
  Hits                            10079    10079           
  Misses                            287      287           
  Partials                            7        7           
Flag Coverage Δ
sql-engine 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MitchellGale MitchellGale merged commit 5f130fb into Integ-fixDocTestProtocol May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants