Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Day_Of_Month Function As An Alias Of DayOfMonth #191

Conversation

GabeFernandez310
Copy link

Description

Adds support for the day_of_month function as an alias for the dayofmonth function which currently exists in opensearch

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dai-chen and others added 3 commits December 14, 2022 09:24
* Add table write operator and builder

Signed-off-by: Chen Dai <[email protected]>

* Add UT for all new classes

Signed-off-by: Chen Dai <[email protected]>

* Rename child field

Signed-off-by: Chen Dai <[email protected]>

* Add columns field

Signed-off-by: Chen Dai <[email protected]>

* Update javadoc to prepare PR

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (integ-add-day_of_month-function@32ad2ff). Click here to learn what that means.
The diff coverage is n/a.

@@                        Coverage Diff                         @@
##             integ-add-day_of_month-function     #191   +/-   ##
==================================================================
  Coverage                                   ?   95.82%           
  Complexity                                 ?     3542           
==================================================================
  Files                                      ?      356           
  Lines                                      ?     9398           
  Branches                                   ?      674           
==================================================================
  Hits                                       ?     9006           
  Misses                                     ?      334           
  Partials                                   ?       58           
Flag Coverage Δ
query-workbench 62.76% <0.00%> (?)
sql-engine 98.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants