Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Alternate Legacy MULTIMATCH syntax #168

Conversation

forestmvey
Copy link

@forestmvey forestmvey commented Nov 16, 2022

Signed-off-by: forestmvey [email protected]

Description

Add support for alternative syntax of MULTI_MATCH relevance search functions. Legacy engine supports parameter keys as quoted, or unquoted values for both required and optional arguments. This syntax has been ported over to all relevance functions in the V2 engine.

Example Queries

SELECT * FROM stackexchange_beer WHERE MULTI_MATCH('query'='cicerone', 'fields'='Tags');
SELECT * FROM stackexchange_beer WHERE MULTIMATCH('query'='cicerone', 'fields'='Tags');
SELECT * FROM stackexchange_beer WHERE MULTIMATCHQUERY('query'='cicerone', fields='Tags');
SELECT * FROM stackexchange_beer WHERE MULTIMATCHQUERY(query='cicerone', 'fields'=['Title,Tags^2.0']);

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch from 2f8e6ed to ea0f277 Compare November 16, 2022 19:42
@forestmvey forestmvey requested a review from a team November 16, 2022 19:43
@forestmvey forestmvey changed the title Dev add alternate multi match syntax Add Support for Alternate Legacy MULTIMATCH syntax Nov 16, 2022
@forestmvey forestmvey marked this pull request as ready for review November 18, 2022 06:54
@forestmvey forestmvey requested a review from a team November 18, 2022 06:55
@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch from be6214c to 6e0b326 Compare November 18, 2022 06:56
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #168 (cfb2650) into integ-add-alternate-multi-match-syntax (cfb2650) will not change coverage.
The diff coverage is n/a.

❗ Current head cfb2650 differs from pull request most recent head b56025c. Consider uploading reports for the commit b56025c to get more accurate results

@@                            Coverage Diff                            @@
##             integ-add-alternate-multi-match-syntax     #168   +/-   ##
=========================================================================
  Coverage                                     98.29%   98.29%           
  Complexity                                     3465     3465           
=========================================================================
  Files                                           347      347           
  Lines                                          8645     8645           
  Branches                                        550      550           
=========================================================================
  Hits                                           8498     8498           
  Misses                                          142      142           
  Partials                                          5        5           
Flag Coverage Δ
sql-engine 98.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch from 6e0b326 to 42ba4fd Compare November 18, 2022 17:08
@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch 4 times, most recently from d4336d2 to 8f80e99 Compare November 22, 2022 17:03
@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch from 8f80e99 to a722d51 Compare November 23, 2022 16:17
@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch from a722d51 to f1a51e8 Compare November 24, 2022 16:23
@forestmvey forestmvey force-pushed the dev-add-alternate-multi-match-syntax branch from f1a51e8 to b56025c Compare November 24, 2022 16:34
@forestmvey forestmvey merged commit 523f974 into integ-add-alternate-multi-match-syntax Nov 24, 2022
@forestmvey forestmvey deleted the dev-add-alternate-multi-match-syntax branch November 24, 2022 17:10
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
* Import h3 library (#154)

Made following changes to make it compatible:
1. Rename package from elasticsearch to opensearch.geospatial
2. Update License headers
3. Update build file
4. Update settings to include sub projects

* Use Transport Request (#164)

Remove usage of deprecated BaseNodeRequest

* Update http client package to resolve build failure (#168) (#171)

* Introduce H3 min resolution constant (#165)

H3 version 1 has 16 resolutions, numbered 0 through 15.
Introduced a constant to represent min value, similar
to max value.

* Add geohex aggregation (#160)

This aggregation will use uber's h3 to group coordinates into H3 cell.
Created new aggregation type geohex_grid. The precision will be between
0 and 15. This aggreation has default precision as 5,
similar to geohash and geotile.

Signed-off-by: Vijayan Balasubramanian <[email protected]>

* Add integration test (#176)

Included integration test for geohex_grid.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants