Updates for comments

Signed-off-by: acarbonetto <[email protected]>
Bit-Quill · Jul 28, 2023 · b1928ae · b1928ae
1 parent 283428c
commit b1928ae
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/request/SqlRequestFactory.java b/legacy/src/main/java/org/opensearch/sql/legacy/request/SqlRequestFactory.java
@@ -63,7 +63,6 @@ private static SqlRequest parseSqlRequestFromPayload(RestRequest restRequest) {
             List<PreparedStatementRequest.PreparedStatementParameter> parameters = parseParameters(paramArray);
             return new PreparedStatementRequest(sql, validateAndGetFetchSize(jsonContent), jsonContent, parameters);
         }
-
         return new SqlRequest(sql, validateAndGetFetchSize(jsonContent), jsonContent);
     }
 
@@ -83,14 +82,6 @@ private static Integer validateAndGetFetchSize(JSONObject jsonContent) {
         return fetchSize.orElse(0);
     }
 
-    private static List<String> parseRoutingIds(JSONArray array) {
-        List<String> routingIds = List.of();
-        for (int i = 0; i < array.length(); i++) {
-            routingIds.add(array.getString(i));
-        }
-        return routingIds;
-    }
-
     private static List<PreparedStatementRequest.PreparedStatementParameter> parseParameters(
             JSONArray paramsJsonArray) {
         List<PreparedStatementRequest.PreparedStatementParameter> parameters = new ArrayList<>();

diff --git a/.../src/test/java/org/opensearch/sql/legacy/plugin/RestSQLQueryActionCursorFallbackTest.java b/.../src/test/java/org/opensearch/sql/legacy/plugin/RestSQLQueryActionCursorFallbackTest.java
@@ -99,7 +99,6 @@ private static SQLQueryRequest createSqlQueryRequest(String query, Optional<Stri
     builder.endObject();
     JSONObject jsonContent = new JSONObject(Strings.toString(builder));
 
-    // TODO pass through
     return  new SQLQueryRequest(jsonContent, query, QUERY_API_ENDPOINT,
         Map.of("format", "jdbc"), cursorId.orElse(""));
   }