Skip to content

Commit

Permalink
Address code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jduo committed Jan 10, 2022
1 parent 5893d51 commit 1d668a1
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ SET(Arrow_STATIC ON)
include(ExternalProject)

set(ARROW_CMAKE_ARGS
# -DCMAKE_TOOLCHAIN_FILE=${DEPENDENCY_PATH}
-DARROW_FLIGHT=ON
-DARROW_FLIGHT_SQL=ON
-DARROW_IPC=ON
Expand All @@ -35,7 +34,6 @@ set(ARROW_CMAKE_ARGS
-DARROW_BUILD_STATIC=ON
-DARROW_COMPUTE=ON
-DARROW_BUILD_TESTS=OFF
# -DARROW_DEPENDENCY_SOURCE=VCPKG
-DARROW_DEPENDENCY_USE_SHARED=OFF
-DCMAKE_DEPENDS_USE_COMPILER=FALSE
-DCMAKE_INSTALL_PREFIX=${CMAKE_CURRENT_BINARY_DIR}/ApacheArrow-prefix/src/ApacheArrow-install
Expand Down Expand Up @@ -72,6 +70,8 @@ find_package(Protobuf REQUIRED)
if (NOT DEFINED OPENSSL_ROOT_DIR AND DEFINED APPLE)
set(OPENSSL_ROOT_DIR /usr/local/Cellar/[email protected]/1.1.1m)
endif()
# This is based on Arrow's FindOpenSSL module. It's not clear if both variables
# need to be set.
set(OpenSSL_USE_STATIC_LIBS ON)
set(OPENSSL_USE_STATIC_LIBS ON)
find_package(OpenSSL REQUIRED)
Expand Down

0 comments on commit 1d668a1

Please sign in to comment.