Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ocean-api): integrate playground with ocean-api #928

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

fuxingloh
Copy link
Contributor

What this PR does / why we need it:

Integrated playground to automatically run when PLAYGROUND_ENABLE is provided on regtest.

@defichain-bot defichain-bot added area/apps kind/feature New feature request labels Dec 31, 2021
@codeclimate
Copy link

codeclimate bot commented Dec 31, 2021

Code Climate has analyzed commit 142779b and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Dec 31, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 142779b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61d40a254f979e81e2d56170

😎 Browse the preview: https://deploy-preview-928--jellyfish-defi.netlify.app

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #928 (142779b) into main (bb5da70) will increase coverage by 1.95%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   93.72%   95.67%   +1.95%     
==========================================
  Files         153      156       +3     
  Lines        4748     4790      +42     
  Branches      613      617       +4     
==========================================
+ Hits         4450     4583     +133     
+ Misses        298      207      -91     
Impacted Files Coverage Δ
apps/ocean-api/src/modules/PlaygroundModule.ts 96.15% <96.15%> (ø)
apps/ocean-api/src/modules/RootModule.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/category/net.ts 71.42% <0.00%> (-28.58%) ⬇️
packages/jellyfish-api-core/src/category/server.ts 71.42% <0.00%> (-28.58%) ⬇️
packages/jellyfish-api-core/src/category/mining.ts 84.61% <0.00%> (-15.39%) ⬇️
...ages/jellyfish-api-core/src/category/blockchain.ts 93.93% <0.00%> (-6.07%) ⬇️
...h-transaction-builder/src/txn/txn_builder_loans.ts 93.93% <0.00%> (-6.07%) ⬇️
...ages/jellyfish-api-core/src/category/masternode.ts 95.23% <0.00%> (-4.77%) ⬇️
...ellyfish-transaction-signature/src/tx_signature.ts 90.80% <0.00%> (-3.45%) ⬇️
packages/jellyfish-wallet-classic/src/classic.ts 100.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5da70...142779b. Read the comment docs.

canonbrother
canonbrother previously approved these changes Jan 4, 2022
monstrobishi
monstrobishi previously approved these changes Jan 4, 2022
surangap
surangap previously approved these changes Jan 4, 2022
chee-chyuan
chee-chyuan previously approved these changes Jan 4, 2022
kodemon
kodemon previously approved these changes Jan 4, 2022
Copy link
Contributor

@kodemon kodemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few questions to gain some more insights into project code conventions as I am still on the very early onboarding track.

@fuxingloh fuxingloh merged commit a0a93ca into main Jan 4, 2022
@fuxingloh fuxingloh deleted the fuxingloh/playground branch January 4, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants