Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain.getBlockchainInfo #89

Merged
merged 4 commits into from
Apr 1, 2021
Merged

blockchain.getBlockchainInfo #89

merged 4 commits into from
Apr 1, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Implemented type for RPC: #48

  1. blockchain.getBlockchainInfo

@netlify
Copy link

netlify bot commented Mar 29, 2021

Deploy preview for jellyfish-defi canceled.

Built with commit 54b2e80

https://app.netlify.com/sites/jellyfish-defi/deploys/6061ee86b3c000000706d952

@defichain-bot defichain-bot added the kind/feature New feature request label Mar 29, 2021
@fuxingloh fuxingloh force-pushed the fuxingloh/rpc-blockchain-1 branch from 724ca7c to 0faeb0e Compare March 29, 2021 15:06
@github-actions
Copy link

github-actions bot commented Mar 29, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 15.76 KB (+0.53% 🔺) 316 ms (+0.53% 🔺) 155 ms (+4.85% 🔺) 470 ms

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #89 (54b2e80) into main (7c9d547) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   93.30%   93.46%   +0.15%     
==========================================
  Files          15       16       +1     
  Lines         254      260       +6     
  Branches       30       30              
==========================================
+ Hits          237      243       +6     
  Misses         15       15              
  Partials        2        2              
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/mining.ts 100.00% <ø> (ø)
...ages/jellyfish-api-core/src/category/blockchain.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9d547...54b2e80. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review March 31, 2021 09:55
@fuxingloh fuxingloh merged commit 501ada3 into main Apr 1, 2021
@fuxingloh fuxingloh deleted the fuxingloh/rpc-blockchain-1 branch April 1, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants