Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highestBid object to listVaults, getVault and listAuctions RPCs #850

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Nov 23, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

If an auction bid is made, display highestBid object that is returned from listVaults, getVault and listAuctions RPCs

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Nov 23, 2021

Code Climate has analyzed commit 21fdb6e and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Nov 23, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 21fdb6e

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/619cd2a35ed613000871fba6

😎 Browse the preview: https://deploy-preview-850--jellyfish-defi.netlify.app

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #850 (21fdb6e) into main (7c7231a) will increase coverage by 1.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   95.21%   96.32%   +1.10%     
==========================================
  Files         140      140              
  Lines        4470     4485      +15     
  Branches      585      586       +1     
==========================================
+ Hits         4256     4320      +64     
+ Misses        214      165      -49     
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/loan.ts 100.00% <ø> (ø)
packages/jellyfish-crypto/src/elliptic.ts 81.81% <0.00%> (-12.13%) ⬇️
...ellyfish-transaction/src/script/dftx/dftx_token.ts 93.02% <0.00%> (-6.98%) ⬇️
packages/jellyfish-crypto/src/der.ts 92.59% <0.00%> (-3.71%) ⬇️
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 95.45% <0.00%> (-1.47%) ⬇️
...ckages/jellyfish-transaction/src/script/mapping.ts 95.27% <0.00%> (-1.31%) ⬇️
...ellyfish-transaction/src/script/dftx/dftx_loans.ts 100.00% <0.00%> (ø)
...jellyfish-transaction/src/script/dftx/dftx_pool.ts 80.00% <0.00%> (+2.50%) ⬆️
...transaction-builder/src/txn/txn_builder_oracles.ts 100.00% <0.00%> (+6.25%) ⬆️
...ish-transaction/src/script/dftx/dftx_governance.ts 100.00% <0.00%> (+8.13%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7231a...21fdb6e. Read the comment docs.

@jingyi2811 jingyi2811 marked this pull request as ready for review November 23, 2021 12:03
@fuxingloh fuxingloh merged commit 2ba2c7f into main Nov 24, 2021
@fuxingloh fuxingloh deleted the jimmy/quick-vault-auction-fix branch November 24, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants