Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Anchors RPC #558

Closed
wants to merge 1 commit into from
Closed

List Anchors RPC #558

wants to merge 1 commit into from

Conversation

siradji
Copy link
Contributor

@siradji siradji commented Aug 4, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Implement listanchors RPC

Which issue(s) does this PR fixes?:

Fixes #48

Additional comments?:

@siradji siradji self-assigned this Aug 4, 2021
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2021

Code Climate has analyzed commit d8fb11c and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 22.35 KB (+0.11% 🔺) 447 ms (+0.11% 🔺) 179 ms (-7.43% 🔽) 626 ms

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: d8fb11c

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/610a4b2ea2e0460009583fe9

😎 Browse the preview: https://deploy-preview-558--jellyfish-defi.netlify.app

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #558 (d8fb11c) into main (c3e429d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   97.42%   97.43%           
=======================================
  Files         112      112           
  Lines        3299     3309   +10     
  Branches      407      408    +1     
=======================================
+ Hits         3214     3224   +10     
  Misses         85       85           
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/masternode.ts 100.00% <100.00%> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.55% <0.00%> (-0.01%) ⬇️
packages/jellyfish-api-core/src/category/spv.ts 100.00% <0.00%> (ø)
packages/jellyfish-wallet-mnemonic/src/hd_node.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e429d...d8fb11c. Read the comment docs.

@siradji
Copy link
Contributor Author

siradji commented Aug 12, 2021

I want to write a test case that asserts the number of anchor that is returned when listAnchors RPC is called. I have tried creating anchors via spv_anchorrewards but no avail.
My questions are

  • What is the difference between spv_listanchors and listanchors?
  • Is there a away to create anchors so that i can make the assertion i outlined above?

@fuxingloh fuxingloh closed this Sep 10, 2021
@fuxingloh fuxingloh deleted the siradji/rpc_listanchors branch September 10, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeFi Blockchain RPC Implementations
3 participants