Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added listBurnHistory RPC #444

Merged
merged 23 commits into from
Jul 25, 2021
Merged

Added listBurnHistory RPC #444

merged 23 commits into from
Jul 25, 2021

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Jul 6, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds listBurnHistory RPC

Which issue(s) does this PR fixes?:

Fixes missing RPC implementation in #48

@netlify
Copy link

netlify bot commented Jul 6, 2021 •
edited
Loading

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 1565440

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60f969144333a900074c8a99

😎 Browse the preview: https://deploy-preview-444--jellyfish-defi.netlify.app

@codeclimate
Copy link

codeclimate bot commented Jul 6, 2021 •
edited
Loading

Code Climate has analyzed commit 1565440 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jul 6, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 21.36 KB (+0.13% 🔺) 428 ms (+0.13% 🔺) 215 ms (+6.45% 🔺) 643 ms

@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #444 (1565440) into main (ad6e422) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         105      105           
  Lines        3052     3056    +4     
  Branches      378      379    +1     
=======================================
+ Hits         2970     2974    +4     
  Misses         82       82
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6e422...1565440. Read the comment docs.

@Jouzo Jouzo marked this pull request as draft July 6, 2021 15:48
@Jouzo Jouzo marked this pull request as ready for review July 7, 2021 06:25
@fuxingloh fuxingloh mentioned this pull request Jul 12, 2021
Open
Jouzo and others added 3 commits July 12, 2021 13:55
@Jouzo Jouzo requested a review from siradji July 12, 2021 12:06
@Jouzo Jouzo requested a review from canonbrother July 16, 2021 13:56
canonbrother
canonbrother reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that still have the duplicated tests but since its added i just ignore it
overall i'm good

@Jouzo
Copy link
Contributor Author

Jouzo commented Jul 19, 2021

Are you talking about the filter by token type @canonbrother ?

@canonbrother
Copy link
Contributor

Are you talking about the filter by token type @canonbrother ?

yes the txtype filter, both txtype filter tests are considered same condition

@Jouzo
Copy link
Contributor Author

Jouzo commented Jul 19, 2021

you're right, let me fix it

aikchun
aikchun reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@aikchun aikchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For assertions that uses .every, since the return type is a boolean, we should probably use .toBe(true) or .toStrictEqual(true), instead of toBeTruthy to be more definitive on what we're testing for.

@fuxingloh fuxingloh dismissed stale reviews from canonbrother and siradji July 25, 2021 19:14

stale

@fuxingloh fuxingloh merged commit 102aa0b into main Jul 25, 2021
@fuxingloh fuxingloh deleted the jouzo/rpc_accounts/listBurnHistory branch July 25, 2021 19:14
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
@defichain-bot
Bump @defichain/jellyfish dependencies (#444)
17bb5a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikchun aikchun aikchun left review comments

@jingyi2811 jingyi2811 jingyi2811 approved these changes

@fuxingloh fuxingloh fuxingloh approved these changes

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@siradji siradji Awaiting requested review from siradji

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

@ivan-zynesis ivan-zynesis Awaiting requested review from ivan-zynesis ivan-zynesis is a code owner

Assignees

@Jouzo Jouzo

Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Jouzo @canonbrother @aikchun @fuxingloh @jingyi2811 @ivan-zynesis @siradji @defichain-bot