jellyfish-core protocol adapter and error handling #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into fuxingloh/container-json-bigint
updated jest and package config
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 91.83% 93.02% +1.18%
==========================================
Files 8 10 +2
Lines 147 172 +25
Branches 18 19 +1
==========================================
+ Hits 135 160 +25
Misses 12 12
Continue to review full report at Codecov.
|
fuxingloh
requested review from
fullstackninja864,
saurabh391 and
thedoublejay
as code owners
fullstackninja864
approved these changes
Mar 8, 2021
thedoublejay
approved these changes
Mar 9, 2021
| isoperator: boolean | ||
| masternodeid?: string | ||
| masternodeoperator?: string | ||
| masternodestate?: 'PRE_ENABLED' | 'ENABLED' | 'PRE_RESIGNED' | 'RESIGNED' | 'PRE_BANNED' | 'BANNED' |
There was a problem hiding this comment.
Nice. I need to add this on my masternode PR (I only have enabled, pre_resigned and resigned)
eli-lim
pushed a commit
that referenced
this pull request
Mar 27, 2022
* added better Create Pull Request body * tested hex_encoder * added module * rename HexEncoder method * updated readme and module * added block.ts with test * added raw.block.ts with test * added script.activity.ts with test * added the rest without testing * fixed ci.yml script
canonbrother
pushed a commit
that referenced
this pull request
Jun 1, 2022
* added better Create Pull Request body * tested hex_encoder * added module * rename HexEncoder method * updated readme and module * added block.ts with test * added raw.block.ts with test * added script.activity.ts with test * added the rest without testing * fixed ci.yml script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
This pull request implements the jellyfish-core abstraction for protocol adapting and error handling.
JellyfishClientbeing an abstract class allows the ability to adapt to any protocol when introduced, ws, https etc while being simple to use. This implementation structure can be observed inContainerAdapterClientwhere it is used to testjellyfish-coreimplementations.RPC categories are grouped into
jellyfish-core/src/category/*.tse.g.category/mining.tsthis allows a protocol agnostic implementation of the RPC. All concerns are grouped within onetsfile for better developer experience of browsing and maintaining code. (might refactor this in the future, but we can leave it as it is now)JellyfishErrorencapsulate RPC errors from DeFiChain within a structure. This allow forinstancesofortype oferror handling with rich structure.Which issue(s) does this PR fixes?:
Fixes #16 and #19
Additional comments?:
Also made changes to testcontainers:
json-bigintin favour of a new cleaner implementation that is to be introducedcontainer.post(string): stringmethod for test adapting