Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getRawTransaction rpc #385

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

canonbrother
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Add getRawTransaction rpc

Which issue(s) does this PR fixes?:

Fixes part of #48

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jun 17, 2021

Code Climate has analyzed commit ba0d185 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: ba0d185

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60cb0b8802bc07000886a47b

😎 Browse the preview: https://deploy-preview-385--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 17, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 20.34 KB (+0.12% 🔺) 407 ms (+0.12% 🔺) 193 ms (-1.11% 🔽) 600 ms

@canonbrother canonbrother force-pushed the canonbrother/rpc-getrawtransaction branch from 0f2f191 to a0db8cc Compare June 17, 2021 05:11
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #385 (03f9f24) into main (9a2e17d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 03f9f24 differs from pull request most recent head ba0d185. Consider uploading reports for the commit ba0d185 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   97.15%   97.17%   +0.01%     
==========================================
  Files          94       94              
  Lines        2675     2686      +11     
  Branches      344      344              
==========================================
+ Hits         2599     2610      +11     
  Misses         76       76              
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/blockchain.ts 100.00% <ø> (ø)
packages/jellyfish-api-core/src/category/oracle.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/category/rawtx.ts 100.00% <100.00%> (ø)
packages/testing/src/poolpair.ts 97.29% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ebb39...ba0d185. Read the comment docs.

@fuxingloh fuxingloh merged commit d4132b7 into main Jun 17, 2021
@fuxingloh fuxingloh deleted the canonbrother/rpc-getrawtransaction branch June 17, 2021 09:02
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
* Fixed tx ordering, added block reward and vout total

* Tests passing

* Refactor tests and rename vout

* PR feedback,. simplified db structure, fixed test

* Fix api test

* Correct test

* Fix test

* Apply suggestions from code review

Co-authored-by: Fuxing Loh <[email protected]>
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
* Fixed tx ordering, added block reward and vout total

* Tests passing

* Refactor tests and rename vout

* PR feedback,. simplified db structure, fixed test

* Fix api test

* Correct test

* Fix test

* Apply suggestions from code review

Co-authored-by: Fuxing Loh <[email protected]>
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
* Fixed tx ordering, added block reward and vout total

* Tests passing

* Refactor tests and rename vout

* PR feedback,. simplified db structure, fixed test

* Fix api test

* Correct test

* Fix test

* Apply suggestions from code review

Co-authored-by: Fuxing Loh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants