Masternode RPC (createmasternode, listmasternodes, getmasternode) #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 03a93f8 and detected 0 issues on this pull request. View more on Code Climate. |
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 03a93f8 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d33cfe2ddcf4000861bf0f 😎 Browse the preview: https://deploy-preview-372--jellyfish-defi.netlify.app |
size-limit report 📦
|
|
You need to update sidebar.js too |
ivan-zynesis
previously requested changes
Jun 11, 2021
packages/jellyfish-api-core/__tests__/category/masternode/createMasternode.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/createMasternode.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/createMasternode.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/getMasternode.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/listMasternodes.test.ts
Outdated
Show resolved
Hide resolved
Okay. Updated now. |
jingyi2811
reviewed
Jun 11, 2021
packages/jellyfish-api-core/__tests__/category/masternode/listMasternodes.test.ts
Outdated
Show resolved
Hide resolved
canonbrother
requested changes
Jun 11, 2021
jingyi2811
reviewed
Jun 11, 2021
jingyi2811
reviewed
Jun 11, 2021
jingyi2811
reviewed
Jun 11, 2021
jingyi2811
reviewed
Jun 11, 2021
jingyi2811
reviewed
Jun 11, 2021
jingyi2811
reviewed
Jun 11, 2021
packages/jellyfish-api-core/__tests__/category/masternode/listMasternodes.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: canonbrother <[email protected]>
Co-authored-by: canonbrother <[email protected]>
Co-authored-by: canonbrother <[email protected]>
jingyi2811
reviewed
Jun 11, 2021
@canonbrother All thanks to you guys for getting some sense into me. Keep it up till i can walk straight! |
Co-authored-by: Fuxing Loh <[email protected]>
fuxingloh
suggested changes
Jun 22, 2021
fuxingloh
suggested changes
Jun 23, 2021
Co-authored-by: Fuxing Loh <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
fuxingloh
reviewed
Jun 23, 2021
packages/jellyfish-api-core/__tests__/category/masternode/getMasternode.test.ts
Outdated
Show resolved
Hide resolved
fuxingloh
reviewed
Jun 23, 2021
fuxingloh
approved these changes
Jun 23, 2021
jingyi2811
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Masternode RPC implementation #48
Which issue(s) does this PR fixes?:
Fixes part of #48
Additional comments?: