Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added listCommunityBalances RPC #368

Merged
merged 9 commits into from
Jun 23, 2021

Conversation

izzycsy
Copy link
Contributor

@izzycsy izzycsy commented Jun 10, 2021

Added listCommunityBalances RPC

What kind of PR is this?:

/kind feature
listCommunityBalances RPC

What this PR does / why we need it:

Implement type for RPC: #48

Should give an output of:

  1. Anchor rewards
  2. Incentive funding
  3. Burnt token(s)

Output currently skipped:

  1. Swap
  2. Futures
  3. Options
  4. Unallocated
  5. Unknown

Add rpc_accounts listCommunityBalances
@codeclimate
Copy link

codeclimate bot commented Jun 10, 2021

Code Climate has analyzed commit a2d93dc and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 10, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: a2d93dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d1b420d461cb0007942f38

😎 Browse the preview: https://deploy-preview-368--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 10, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 20.51 KB (+0.13% 🔺) 411 ms (+0.13% 🔺) 165 ms (-4.46% 🔽) 575 ms

@monstrobishi
Copy link
Contributor

Suggest renaming PR to Added listCommunityBalances RPC

@monstrobishi
Copy link
Contributor

/kind feature

@izzycsy izzycsy changed the title /kind feature /kind feature Added listCommunityBalances RPC Jun 10, 2021
Added listCommunityBalances RPC
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #368 (a2d93dc) into main (d26d5e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          94       94           
  Lines        2750     2752    +2     
  Branches      346      346           
=======================================
+ Hits         2675     2677    +2     
  Misses         75       75           
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26d5e1...a2d93dc. Read the comment docs.

@fuxingloh fuxingloh changed the title /kind feature Added listCommunityBalances RPC Add listCommunityBalances RPC Jun 10, 2021
@jingyi2811 jingyi2811 marked this pull request as draft June 11, 2021 12:06
- remove extra break line
- updated #listCommunityBalances definition
@izzycsy izzycsy changed the title Add listCommunityBalances RPC Added listCommunityBalances RPC Jun 15, 2021
canonbrother
canonbrother previously approved these changes Jun 16, 2021
@jingyi2811
Copy link
Contributor

I convert this PR from draft to review for review

@jingyi2811 jingyi2811 marked this pull request as ready for review June 16, 2021 03:21
@jingyi2811
Copy link
Contributor

I have approved this PR.

Suggestion: In your future code don't use
import { BigNumber } from '@defichain/jellyfish-json'

Use import BigNumber from 'bignumber.js'

See https://github.com/DeFiCh/jellyfish/blob/983205261be1923e99e1686ee9eb93277cfdb0ab/packages/jellyfish-api-core/src/category/account.ts#L1

jingyi2811
jingyi2811 previously approved these changes Jun 16, 2021
@fuxingloh
Copy link
Contributor

I have approved this PR.

Suggestion: In your future code don't use
import { BigNumber } from '@defichain/jellyfish-json'

Use import BigNumber from 'bignumber.js'

See

https://github.com/DeFiCh/jellyfish/blob/983205261be1923e99e1686ee9eb93277cfdb0ab/packages/jellyfish-api-core/src/category/account.ts#L1

@izzycsy let's fix this before merge

@fuxingloh fuxingloh marked this pull request as draft June 16, 2021 07:23
@izzycsy izzycsy dismissed stale reviews from jingyi2811 and canonbrother via 2fde04b June 16, 2021 08:19
jingyi2811
jingyi2811 previously approved these changes Jun 16, 2021
@jingyi2811 jingyi2811 marked this pull request as ready for review June 16, 2021 10:02
@fuxingloh fuxingloh marked this pull request as draft June 21, 2021 08:42
@izzycsy izzycsy marked this pull request as ready for review June 22, 2021 08:29
canonbrother
canonbrother previously approved these changes Jun 22, 2021
@fuxingloh fuxingloh enabled auto-merge (squash) June 22, 2021 11:06
@fuxingloh fuxingloh merged commit cd2603e into main Jun 23, 2021
@fuxingloh fuxingloh deleted the izzy/rpc-accounts-listcommunitybalances branch June 23, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants