-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getBalances RPC #362
Conversation
Code Climate has analyzed commit b999820 and detected 0 issues on this pull request. View more on Code Climate. |
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: b999820 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d1e3d7c6dfe30007c144d6 😎 Browse the preview: https://deploy-preview-362--jellyfish-defi.netlify.app |
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 94 94
Lines 2750 2752 +2
Branches 346 346
=======================================
+ Hits 2675 2677 +2
Misses 75 75
Continue to review full report at Codecov.
|
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
27bb821
to
270ef03
Compare
5b0d10a
to
c6283bc
Compare
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing withTokens = true
test and minor refactors
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
There's a strange behavior regarding the balances when
But they can't be referenced like a normal object nor are they instances of Not too sure if this is the intended behavior. If it is, could require some insight on how to test this. |
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/wallet/getBalances.test.ts
Outdated
Show resolved
Hide resolved
|
…hOnlyBalance to WalletBalances, WalletMineBalances and WalletWatchOnlyBalances respectively.
…r instead of converting it into number.
1079fb5
to
b999820
Compare
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Implemented RPC for #48
Which issue(s) does this PR fixes?:
Additional comments?: