-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wallet.getUnconfirmedBalance
RPC
#354
Conversation
Code Climate has analyzed commit a17ab33 and detected 0 issues on this pull request. View more on Code Climate. |
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: a17ab33 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d035f7cb4fa900088e766e 😎 Browse the preview: https://deploy-preview-354--jellyfish-defi.netlify.app |
size-limit report 📦
|
ee98eae
to
a9218be
Compare
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 92.98% 97.21% +4.22%
==========================================
Files 10 94 +84
Lines 171 2690 +2519
Branches 19 344 +325
==========================================
+ Hits 159 2615 +2456
- Misses 12 75 +63
Continue to review full report at Codecov.
|
packages/jellyfish-api-core/__tests__/category/wallet/getUnconfirmedBalance.test.ts
Outdated
Show resolved
Hide resolved
… assertions on unconfirmedbalance.
87de5af
to
a17ab33
Compare
wallet.getUnconfirmedBalance
RPC
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Added getUnconfirmedBalance RPC
Which issue(s) does this PR fixes?:
Fixes
getunconfirmedbalance
#48Did not test for
getUnconfirmedBalance(true)
because it is not tested or used any where in any app.Did not test for
untrusted_pending
because requires multi-node set up.