Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wallet.getUnconfirmedBalance RPC #354

Merged
merged 10 commits into from
Jun 21, 2021
Merged

Conversation

aikchun
Copy link
Contributor

@aikchun aikchun commented Jun 8, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Added getUnconfirmedBalance RPC

  1. wallet.getUnconfirmedBalance

Which issue(s) does this PR fixes?:

Fixes getunconfirmedbalance #48

Did not test for getUnconfirmedBalance(true) because it is not tested or used any where in any app.
Did not test for untrusted_pending because requires multi-node set up.

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2021

Code Climate has analyzed commit a17ab33 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 8, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: a17ab33

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d035f7cb4fa900088e766e

😎 Browse the preview: https://deploy-preview-354--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 20.37 KB (+0.09% 🔺) 408 ms (+0.09% 🔺) 170 ms (-2.41% 🔽) 578 ms

@aikchun aikchun force-pushed the aikchun/getunconfirmedbalance branch from ee98eae to a9218be Compare June 17, 2021 02:12
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #354 (a17ab33) into main (00986ae) will increase coverage by 4.22%.
The diff coverage is 98.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   92.98%   97.21%   +4.22%     
==========================================
  Files          10       94      +84     
  Lines         171     2690    +2519     
  Branches       19      344     +325     
==========================================
+ Hits          159     2615    +2456     
- Misses         12       75      +63     
Impacted Files Coverage Δ
...llyfish-transaction/src/buffer/buffer_bignumber.ts 100.00% <ø> (ø)
...jellyfish-transaction/src/buffer/buffer_bitmask.ts 100.00% <ø> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.50% <ø> (ø)
...jellyfish-transaction/src/buffer/buffer_varuint.ts 100.00% <ø> (ø)
packages/jellyfish-transaction/src/index.ts 100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/_buffer.ts 100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/bitwise.ts 100.00% <ø> (ø)
...ages/jellyfish-transaction/src/script/constants.ts 100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/control.ts 100.00% <ø> (ø)
...ackages/jellyfish-transaction/src/script/crypto.ts 100.00% <ø> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e0dde...a17ab33. Read the comment docs.

@aikchun aikchun marked this pull request as ready for review June 17, 2021 06:55
canonbrother
canonbrother previously approved these changes Jun 17, 2021
jingyi2811
jingyi2811 previously approved these changes Jun 18, 2021
@aikchun aikchun force-pushed the aikchun/getunconfirmedbalance branch from 87de5af to a17ab33 Compare June 21, 2021 06:47
@fuxingloh fuxingloh changed the title Added getunconfirmedbalance RPC Added wallet.getUnconfirmedBalance RPC Jun 21, 2021
@fuxingloh fuxingloh enabled auto-merge (squash) June 21, 2021 07:07
@fuxingloh fuxingloh merged commit 437674a into main Jun 21, 2021
@fuxingloh fuxingloh deleted the aikchun/getunconfirmedbalance branch June 21, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants