Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @defichain/testcontainers with chainparams QOL changes #329

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind dependencies

What this PR does / why we need it:

QOL changes for jellyfish, see DeFiCh/ain#464

@defichain-bot defichain-bot added area/testcontainers kind/dependencies Pull requests that update a dependency file labels Jun 2, 2021
@codeclimate
Copy link

codeclimate bot commented Jun 2, 2021

Code Climate has analyzed commit 837428a and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.6 KB (0%) 393 ms (0%) 187 ms (+13.03% 🔺) 579 ms

@fuxingloh fuxingloh added the priority/urgent-now Urgent fix, as fast as possible label Jun 2, 2021
@fuxingloh fuxingloh force-pushed the fuxingloh/fast-track-1.7.x-chainparams branch from 900fa11 to e741b79 Compare June 2, 2021 05:44
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #329 (837428a) into main (23d0cb4) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   97.12%   97.05%   -0.08%     
==========================================
  Files          91       91              
  Lines        2577     2577              
  Branches      327      327              
==========================================
- Hits         2503     2501       -2     
- Misses         74       76       +2     
Impacted Files Coverage Δ
...kages/testcontainers/src/chains/defid_container.ts 93.75% <100.00%> (ø)
...ainers/src/chains/reg_test_container/masternode.ts 94.44% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d0cb4...837428a. Read the comment docs.

@jingyi2811 jingyi2811 self-requested a review June 2, 2021 06:56
@fuxingloh fuxingloh merged commit 0629109 into main Jun 2, 2021
@fuxingloh fuxingloh deleted the fuxingloh/fast-track-1.7.x-chainparams branch June 2, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Pull requests that update a dependency file priority/urgent-now Urgent fix, as fast as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants