-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet.dumpPrivKey
and wallet.importPrivKey
RPC
#306
Conversation
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 8f5c6f5 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b2ca746fd0910007cfd416 😎 Browse the preview: https://deploy-preview-306--jellyfish-defi.netlify.app |
size-limit report 📦
|
Code Climate has analyzed commit 8f5c6f5 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 96.92% 97.04% +0.12%
==========================================
Files 89 91 +2
Lines 2408 2507 +99
Branches 308 318 +10
==========================================
+ Hits 2334 2433 +99
Misses 74 74
Continue to review full report at Codecov.
|
Co-authored-by: Fuxing Loh <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good.. but we have a new test structure.. gonna refactor a bit
@canonbrother, i have implemented that. |
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
RPC wallet implementation #48
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: