Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet.dumpPrivKey and wallet.importPrivKey RPC #306

Merged
merged 8 commits into from
May 30, 2021

Conversation

siradji
Copy link
Contributor

@siradji siradji commented May 27, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

RPC wallet implementation #48

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@netlify
Copy link

netlify bot commented May 27, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 8f5c6f5

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b2ca746fd0910007cfd416

😎 Browse the preview: https://deploy-preview-306--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented May 27, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.6 KB (+0.45% 🔺) 393 ms (+0.45% 🔺) 185 ms (+4.29% 🔺) 577 ms

@codeclimate
Copy link

codeclimate bot commented May 27, 2021

Code Climate has analyzed commit 8f5c6f5 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #306 (8f5c6f5) into main (7f78136) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   96.92%   97.04%   +0.12%     
==========================================
  Files          89       91       +2     
  Lines        2408     2507      +99     
  Branches      308      318      +10     
==========================================
+ Hits         2334     2433      +99     
  Misses         74       74              
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/wallet.ts 100.00% <100.00%> (ø)
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <0.00%> (ø)
...ackages/jellyfish-transaction-builder/src/index.ts 100.00% <0.00%> (ø)
...ellyfish-transaction/src/script/defi/dftx_token.ts 100.00% <0.00%> (ø)
...h-transaction-builder/src/txn/txn_builder_error.ts 100.00% <0.00%> (ø)
...transaction-builder/src/txn/txn_builder_oracles.ts 100.00% <0.00%> (ø)
...ish-transaction/src/script/defi/dftx_governance.ts 100.00% <0.00%> (ø)
...ages/jellyfish-transaction/src/script/defi/dftx.ts 97.29% <0.00%> (+0.28%) ⬆️
...ckages/jellyfish-transaction/src/script/mapping.ts 96.51% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f78136...8f5c6f5. Read the comment docs.

@siradji siradji marked this pull request as ready for review May 28, 2021 08:06
@siradji siradji requested a review from thedoublejay as a code owner May 28, 2021 08:06
website/docs/jellyfish/api/wallet.md Outdated Show resolved Hide resolved
packages/jellyfish-api-core/src/category/wallet.ts Outdated Show resolved Hide resolved
@fuxingloh fuxingloh marked this pull request as draft May 28, 2021 08:11
Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good.. but we have a new test structure.. gonna refactor a bit

@siradji
Copy link
Contributor Author

siradji commented May 28, 2021

overall looks good.. but we have a new test structure.. gonna refactor a bit

@canonbrother, i have implemented that.

@siradji siradji marked this pull request as ready for review May 28, 2021 12:54
fuxingloh
fuxingloh previously approved these changes May 28, 2021
@fuxingloh fuxingloh requested a review from canonbrother May 28, 2021 17:57
@fuxingloh fuxingloh enabled auto-merge (squash) May 28, 2021 17:57
@fuxingloh fuxingloh self-requested a review May 29, 2021 13:52
@fuxingloh fuxingloh merged commit fe81e3f into main May 30, 2021
@fuxingloh fuxingloh deleted the siradji/wallet_dumprivkey_importprivkey branch May 30, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants