-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor account
RPCs tests
#301
Conversation
@jingyi2811: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 86fc19a 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b6102c0fa20000078df9d4 😎 Browse the preview: https://deploy-preview-301--jellyfish-defi.netlify.app |
Code Climate has analyzed commit a7b81c3 and detected 0 issues on this pull request. View more on Code Climate. |
size-limit report 📦
|
packages/jellyfish-api-core/__tests__/category/account/getAccount.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 97.05% 97.09% +0.03%
==========================================
Files 91 91
Lines 2514 2545 +31
Branches 319 323 +4
==========================================
+ Hits 2440 2471 +31
Misses 74 74
Continue to review full report at Codecov.
|
packages/jellyfish-api-core/__tests__/category/account/getAccount.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/getAccount.test.ts
Outdated
Show resolved
Hide resolved
…fish into jimmy/refactor-account-test � Conflicts: � packages/jellyfish-api-core/__tests__/category/account.test.ts
…fish into jimmy/refactor-account-test
Suraj will be the owner of this PR |
…if 'OP_DEFI_TX' is found (#301)
…if 'OP_DEFI_TX' is found (#301)
What kind of PR is this?:
/kind refactor
What this PR does / why we need it:
It’s getting very difficult to maintain side-effect and writing independent tests. Writing a clean and independent test is not easy, it requires a certain mastery with strong testing principles. Refactoring tests in jellyfish-api-core will allow us to have a cleaner testing culture.
Which issue(s) does this PR fixes?:
Fixes #295
Additional comments?: