Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor account RPCs tests #301

Merged
merged 18 commits into from
Jun 2, 2021
Merged

Refactor account RPCs tests #301

merged 18 commits into from
Jun 2, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented May 27, 2021

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

It’s getting very difficult to maintain side-effect and writing independent tests. Writing a clean and independent test is not easy, it requires a certain mastery with strong testing principles. Refactoring tests in jellyfish-api-core will allow us to have a cleaner testing culture.

Which issue(s) does this PR fixes?:

Fixes #295

Additional comments?:

@jingyi2811 jingyi2811 changed the title Refactor all test for account be independent Refactor all test for account to be independent May 27, 2021
@defichain-bot defichain-bot added the needs/kind Needs kind label label May 27, 2021
@defichain-bot
Copy link
Contributor

@jingyi2811: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind fix
  • /kind chore
  • /kind docs
  • /kind refactor
  • /kind dependencies
Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@netlify
Copy link

netlify bot commented May 27, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 86fc19a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b6102c0fa20000078df9d4

😎 Browse the preview: https://deploy-preview-301--jellyfish-defi.netlify.app

@codeclimate
Copy link

codeclimate bot commented May 27, 2021

Code Climate has analyzed commit a7b81c3 and detected 0 issues on this pull request.

View more on Code Climate.

@jingyi2811 jingyi2811 marked this pull request as draft May 27, 2021 07:51
@jingyi2811 jingyi2811 changed the title Refactor all test for account to be independent Refactor all test of account rpcs to be independent May 27, 2021
@jingyi2811 jingyi2811 changed the title Refactor all test of account rpcs to be independent Refactor account rpcs May 27, 2021
@github-actions
Copy link

github-actions bot commented May 27, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.6 KB (0%) 393 ms (0%) 156 ms (-0.03% 🔽) 549 ms

@fuxingloh fuxingloh added the kind/refactor Non feature refactor change label May 27, 2021
@defichain-bot defichain-bot removed the needs/kind Needs kind label label May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #301 (8f2be4b) into main (6554eff) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 8f2be4b differs from pull request most recent head a7b81c3. Consider uploading reports for the commit a7b81c3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   97.05%   97.09%   +0.03%     
==========================================
  Files          91       91              
  Lines        2514     2545      +31     
  Branches      319      323       +4     
==========================================
+ Hits         2440     2471      +31     
  Misses         74       74              
Impacted Files Coverage Δ
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.48% <100.00%> (+0.01%) ⬆️
...ages/jellyfish-transaction/src/script/defi/dftx.ts 97.36% <100.00%> (+0.07%) ⬆️
...jellyfish-transaction/src/script/defi/dftx_pool.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.59% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e7f9c...a7b81c3. Read the comment docs.

@fuxingloh fuxingloh changed the title Refactor account rpcs Refactor account RPCs tests May 27, 2021
@jingyi2811 jingyi2811 assigned siradji and unassigned jingyi2811 and siradji Jun 1, 2021
@jingyi2811
Copy link
Contributor Author

Suraj will be the owner of this PR

@siradji siradji marked this pull request as ready for review June 1, 2021 16:10
@fuxingloh fuxingloh enabled auto-merge (squash) June 2, 2021 00:59
@fuxingloh fuxingloh merged commit 6b7299e into main Jun 2, 2021
@fuxingloh fuxingloh deleted the jimmy/refactor-account-test branch June 2, 2021 03:03
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Non feature refactor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor all test in jellyfish-api-core to be independent
5 participants