Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ci script not failing #257

Merged
merged 1 commit into from
May 19, 2021
Merged

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

CI script not failing as it attempts to fix.

@github-actions
Copy link

github-actions bot commented May 19, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.95 KB (0%) 380 ms (0%) 174 ms (-8.35% 🔽) 553 ms

test failure

fixed ci script not failing
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #257 (d967251) into main (cfbed46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d967251 differs from pull request most recent head e2f4426. Consider uploading reports for the commit e2f4426 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files          82       82           
  Lines        2153     2155    +2     
  Branches      275      275           
=======================================
+ Hits         2075     2077    +2     
  Misses         78       78           
Impacted Files Coverage Δ
packages/jellyfish-transaction/src/index.ts 100.00% <100.00%> (ø)
packages/testing/src/account.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbed46...e2f4426. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review May 19, 2021 13:11
@fuxingloh fuxingloh merged commit ece0fdc into main May 19, 2021
@fuxingloh fuxingloh deleted the fuxingloh/ci-lint-not-failing branch May 19, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants