Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utxosToAccount rpc #215

Merged
merged 20 commits into from
May 19, 2021
Merged

Add utxosToAccount rpc #215

merged 20 commits into from
May 19, 2021

Conversation

jingyi2811
Copy link
Contributor

/kind feature

Add utxosToAccount rpc

@jingyi2811 jingyi2811 marked this pull request as draft May 12, 2021 13:27
@netlify
Copy link

netlify bot commented May 12, 2021

Deploy preview for jellyfish-defi ready!

Built with commit 8e14fbe

https://deploy-preview-215--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented May 12, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.95 KB (+0.11% 🔺) 380 ms (+0.11% 🔺) 176 ms (+0.69% 🔺) 555 ms

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #215 (d5a2bf1) into main (904edd3) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head d5a2bf1 differs from pull request most recent head 8e14fbe. Consider uploading reports for the commit 8e14fbe to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   96.36%   96.23%   -0.14%     
==========================================
  Files          65       66       +1     
  Lines        1652     1699      +47     
  Branches      222      235      +13     
==========================================
+ Hits         1592     1635      +43     
- Misses         60       64       +4     
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <100.00%> (ø)
...ainers/src/chains/reg_test_container/masternode.ts 94.44% <0.00%> (-3.52%) ⬇️
packages/testing/src/token.ts 100.00% <0.00%> (ø)
packages/jellyfish-crypto/src/index.ts 100.00% <0.00%> (ø)
packages/jellyfish-crypto/src/bech32.ts 100.00% <0.00%> (ø)
packages/jellyfish-api-core/src/category/mining.ts 100.00% <0.00%> (ø)
packages/jellyfish-crypto/src/bs58.ts 94.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904edd3...8e14fbe. Read the comment docs.

Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit is polluted, kindly revert back those unnecessary changes on this PR, that should not affect your test

packages/jellyfish-api-core/src/category/account.ts Outdated Show resolved Hide resolved
@jingyi2811
Copy link
Contributor Author

Could you please review this again?
If looks good then only I add comments / other texts

@jingyi2811 jingyi2811 marked this pull request as ready for review May 16, 2021 13:26
canonbrother
canonbrother previously approved these changes May 17, 2021
@fuxingloh fuxingloh enabled auto-merge (squash) May 19, 2021 05:26
@fuxingloh fuxingloh merged commit 355a30b into main May 19, 2021
@fuxingloh fuxingloh deleted the jimmy/utxosToAccount branch May 19, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants