Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages/testcontainers): allow neutral voting #2014

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

shohamc1
Copy link
Contributor

What this PR does / why we need it:

Fixes test failures for DeFiCh/ain#1709

@codeclimate
Copy link

codeclimate bot commented Jan 30, 2023

Code Climate has analyzed commit d479ce1 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit d479ce1
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63dc9441d492120008455b41
😎 Deploy Preview https://deploy-preview-2014--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 92.17% // Head: 92.50% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (d479ce1) compared to base (8b7e028).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
+ Coverage   92.17%   92.50%   +0.33%     
==========================================
  Files         367      367              
  Lines       11026    11026              
  Branches     1436     1436              
==========================================
+ Hits        10163    10200      +37     
+ Misses        828      794      -34     
+ Partials       35       32       -3     
Impacted Files Coverage Δ
...ontainers/src/containers/RegTestContainer/index.ts 100.00% <ø> (ø)
...es/testcontainers/src/containers/DeFiDContainer.ts 91.11% <100.00%> (ø)
packages/whale-api-client/src/api/transactions.ts 25.00% <0.00%> (-75.00%) ⬇️
packages/whale-api-client/src/api/consortium.ts 33.33% <0.00%> (-66.67%) ⬇️
...api/src/module.indexer/model/dftx/update.oracle.ts 37.20% <0.00%> (-60.47%) ⬇️
...-api-client/src/errors/client.timeout.exception.ts 50.00% <0.00%> (-50.00%) ⬇️
...transaction-builder/src/txn/txn_builder_account.ts 56.75% <0.00%> (-43.25%) ⬇️
...ule.indexer/model/dftx/set.oracle.data.interval.ts 61.40% <0.00%> (-35.09%) ⬇️
...h-transaction-builder/src/txn/txn_builder_token.ts 71.42% <0.00%> (-28.58%) ⬇️
...action-builder/src/txn/txn_builder_icxorderbook.ts 71.42% <0.00%> (-28.58%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit b3eed65

  • ghcr.io/jellyfishsdk/legacy-api:pr-2014
  • ghcr.io/jellyfishsdk/playground-api:pr-2014
  • ghcr.io/jellyfishsdk/status-api:pr-2014
  • ghcr.io/jellyfishsdk/whale-api:pr-2014

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:b3eed65efc58d001c56023b3900d7571bf6d60ac
  • ghcr.io/jellyfishsdk/playground-api:b3eed65efc58d001c56023b3900d7571bf6d60ac
  • ghcr.io/jellyfishsdk/status-api:b3eed65efc58d001c56023b3900d7571bf6d60ac
  • ghcr.io/jellyfishsdk/whale-api:b3eed65efc58d001c56023b3900d7571bf6d60ac

@fuxingloh fuxingloh merged commit a60765d into main Feb 3, 2023
@fuxingloh fuxingloh deleted the shohamc1/proposal-changes branch February 3, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants