feat(jellyfish-api-core): add getBlockTemplate RPC #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocteurPing
requested review from
fuxingloh,
canonbrother and
ivan-zynesis
as code owners
github-actions
bot
added
apps/website
area/packages
kind/feature
|
Code Climate has analyzed commit d8dab77 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 59.81% // Head: 85.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
===========================================
+ Coverage 59.81% 85.53% +25.72%
===========================================
Files 290 358 +68
Lines 9331 10795 +1464
Branches 1251 1410 +159
===========================================
+ Hits 5581 9234 +3653
+ Misses 3528 1483 -2045
+ Partials 222 78 -144
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Docker build preview for jellyfish/apps is ready! Built with commit 083d745
You can also get an immutable image with the commit hash
|
fuxingloh
suggested changes
Jan 26, 2023
Comment on lines
57
to
63
| * @param {TemplateRquest} templateRequest A json object in the following spec | ||
| * @param {string} mode This must be set to 'template', 'proposal' (see BIP 23), or omitted | ||
| * @param {string[]} capabilities client side supported feature, 'longpoll', 'coinbasetxn', 'coinbasevalue', 'proposal', 'serverlist', 'workid' | ||
| * @param {string[]} rules A list of strings | ||
| * @returns {Promise<void>} | ||
| */ | ||
| async getBlockTemplate (templateRequest: TemplateRquest): Promise<JSON> { |
There was a problem hiding this comment.
Promise<JSON>? It should be typed.
Co-authored-by: Fuxing Loh <[email protected]> Signed-off-by: DrPing <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]> Signed-off-by: DrPing <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]> Signed-off-by: DrPing <[email protected]>
fuxingloh
reviewed
Feb 1, 2023
docs/node/CATEGORIES/02-mining.md
Outdated
|
|
||
| ```ts title="client.mining.getBlockTemplate()" | ||
| interface mining { | ||
| getBlockTemplate (templateRequest: TemplateRequest): Promise<JSON> |
fuxingloh
suggested changes
Feb 1, 2023
Co-authored-by: Fuxing Loh <[email protected]> Signed-off-by: DrPing <[email protected]>
Co-authored-by: Fuxing Loh <[email protected]> Signed-off-by: DrPing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds getBlockTemplate RPC, tests and documentation.
Which issue(s) does this PR fixes?:
Fixes part of #48
Additional comments?: