Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/ocean-api): removing ocean-api to save CI time #1985

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

fuxingloh
Copy link
Contributor

What this PR does / why we need it:

The high failure rate of docker images recently — to reduce CI time due to failure and having to retry them. I've removed apps/ocean-api , and ocean-api-client is kept intact as it provide the abstraction for both playground-api-client and whale-api-client (although not implemented yet for whale).

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit d288e15
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63c8ec2a26fb5e00089352c2
😎 Deploy Preview https://deploy-preview-1985--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 19, 2023

Code Climate has analyzed commit d288e15 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 92.82% // Head: 92.47% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (d288e15) compared to base (5c44e0e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
- Coverage   92.82%   92.47%   -0.35%     
==========================================
  Files         368      363       -5     
  Lines       10826    10762      -64     
  Branches     1377     1370       -7     
==========================================
- Hits        10049     9952      -97     
- Misses        749      781      +32     
- Partials       28       29       +1     
Impacted Files Coverage Δ
packages/ocean-api-client/src/OceanApiClient.ts 56.60% <ø> (-1.58%) ⬇️
packages/ocean-api-client/src/apis/RawTx.ts 25.00% <ø> (-75.00%) ⬇️
packages/whale-api-client/src/api/blocks.ts 25.00% <0.00%> (-75.00%) ⬇️
...nsaction-builder/src/txn/txn_builder_masternode.ts 33.33% <0.00%> (-66.67%) ⬇️
...egacy-api/src/controllers/stats/StatsController.ts 25.92% <0.00%> (-62.97%) ⬇️
packages/whale-api-client/src/api/consortium.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/whale-api-client/src/api/prices.ts 26.08% <0.00%> (-47.83%) ⬇️
packages/jellyfish-address/src/script/P2PKH.ts 54.16% <0.00%> (-45.84%) ⬇️
...y-api/src/controllers/stats/LegacyStatsProvider.ts 47.36% <0.00%> (-45.62%) ⬇️
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit 41c1d72

  • ghcr.io/jellyfishsdk/legacy-api:pr-1985
  • ghcr.io/jellyfishsdk/playground-api:pr-1985
  • ghcr.io/jellyfishsdk/status-api:pr-1985
  • ghcr.io/jellyfishsdk/whale-api:pr-1985

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:41c1d7275e642de23bda9546e1308dd5af44d6b9
  • ghcr.io/jellyfishsdk/playground-api:41c1d7275e642de23bda9546e1308dd5af44d6b9
  • ghcr.io/jellyfishsdk/status-api:41c1d7275e642de23bda9546e1308dd5af44d6b9
  • ghcr.io/jellyfishsdk/whale-api:41c1d7275e642de23bda9546e1308dd5af44d6b9

@fuxingloh fuxingloh marked this pull request as ready for review January 19, 2023 07:27
@fuxingloh fuxingloh merged commit c43c41c into main Jan 19, 2023
@fuxingloh fuxingloh deleted the fuxingloh/ocean-api-remove branch January 19, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant