Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): add submitBlock RPC #1980

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

DocteurPing
Copy link

What this PR does / why we need it:

This PR add the function submitBlock to Jellyfish

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit d788a72 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit c92a562
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63d9eeb2561e110009c8e6bb
😎 Deploy Preview https://deploy-preview-1980--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fuxingloh fuxingloh requested a review from shohamc1 January 18, 2023 05:53
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 91.22% // Head: 89.21% // Decreases project coverage by -2.02% ⚠️

Coverage data is based on head (c92a562) compared to base (050a0a2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   91.22%   89.21%   -2.02%     
==========================================
  Files         368      366       -2     
  Lines       10829    10992     +163     
  Branches     1378     1434      +56     
==========================================
- Hits         9879     9806      -73     
- Misses        908     1132     +224     
- Partials       42       54      +12     
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/mining.ts 86.66% <0.00%> (-13.34%) ⬇️
packages/whale-api-client/src/api/transactions.ts 25.00% <0.00%> (-75.00%) ⬇️
...playground-api/src/controllers/WalletController.ts 26.19% <0.00%> (-73.81%) ⬇️
apps/whale-api/src/module.api/stats.controller.ts 29.00% <0.00%> (-67.94%) ⬇️
packages/playground/src/bots/BlockGenerateBot.ts 33.33% <0.00%> (-66.67%) ⬇️
...s/playground-api-client/src/PlaygroundRpcClient.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/playground-api-client/src/apis/Wallet.ts 16.66% <0.00%> (-66.67%) ⬇️
...pps/whale-api/src/module.api/masternode.service.ts 27.27% <0.00%> (-66.67%) ⬇️
...pps/whale-api/src/module.health/probe.indicator.ts 37.50% <0.00%> (-62.50%) ⬇️
apps/whale-api/src/module.model/_model.probes.ts 26.66% <0.00%> (-60.00%) ⬇️
... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 18, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit f06f294

  • ghcr.io/jellyfishsdk/legacy-api:pr-1980
  • ghcr.io/jellyfishsdk/playground-api:pr-1980
  • ghcr.io/jellyfishsdk/status-api:pr-1980
  • ghcr.io/jellyfishsdk/whale-api:pr-1980

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:f06f294ffd6b996ae1d77dd69349915d1dc834a7
  • ghcr.io/jellyfishsdk/playground-api:f06f294ffd6b996ae1d77dd69349915d1dc834a7
  • ghcr.io/jellyfishsdk/status-api:f06f294ffd6b996ae1d77dd69349915d1dc834a7
  • ghcr.io/jellyfishsdk/whale-api:f06f294ffd6b996ae1d77dd69349915d1dc834a7

@fuxingloh fuxingloh marked this pull request as draft January 19, 2023 07:24
@fuxingloh fuxingloh changed the title feat(mining): add function submitBlock feat(jellyfish-api-core): add submitBlock RPC Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants