chore(jellyfish-api-core): Change assert order in getMiningInfo.test.ts to match other tests
#1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
requested review from
fuxingloh,
canonbrother and
ivan-zynesis
as code owners
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Code Climate has analyzed commit 9d33d7d and detected 0 issues on this pull request. View more on Code Climate. |
fuxingloh
approved these changes
Nov 21, 2022
Codecov ReportBase: 93.96% // Head: 92.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
- Coverage 93.96% 92.00% -1.97%
==========================================
Files 361 355 -6
Lines 10472 10290 -182
Branches 1316 1293 -23
==========================================
- Hits 9840 9467 -373
- Misses 606 786 +180
- Partials 26 37 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Docker build preview for jellyfish/apps is ready! Built with commit c763ef0
You can also get an immutable image with the commit hash
|
marktanrj
pushed a commit
that referenced
this pull request
Nov 22, 2022
….ts` to match other tests (#1865) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: Uses to the assertion order used by all other tests. Uses a regex pattern to match instead of `toContain`. #### Additional comments?: As requested in #1841 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Uses to the assertion order used by all other tests. Uses a regex pattern to match instead of
toContain.Additional comments?:
As requested in #1841 (comment)