Add getNetworkInfo rpc #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for jellyfish-defi ready! Built with commit b263e44 |
size-limit report 📦
|
canonbrother
previously approved these changes
May 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 95.50% 95.10% -0.40%
==========================================
Files 56 56
Lines 1180 1186 +6
Branches 149 150 +1
==========================================
+ Hits 1127 1128 +1
- Misses 50 55 +5
Partials 3 3
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
May 3, 2021
website/docs/jellyfish/api/net.md
Outdated
Comment on lines
36
to
63
| version: number | ||
| subversion: string | ||
| protocolversion: number | ||
| localservices: string | ||
| localrelay: boolean | ||
| timeoffset: number | ||
| connections: number | ||
| networkactive: boolean | ||
| networks: Network[] | ||
| relayfee: number | ||
| incrementalfee: number, | ||
| localaddresses: LocalAddress[], | ||
| warnings: string | ||
| } | ||
|
|
||
| interface Network { | ||
| name: string, | ||
| limited: boolean, | ||
| reachable: boolean, | ||
| proxy: string, | ||
| proxy_randomize_credentials: boolean | ||
| } | ||
|
|
||
| interface LocalAddress { | ||
| address: string, | ||
| port: number, | ||
| score: number | ||
| } |
There was a problem hiding this comment.
commas consistency, you should follow net.ts
note because npm run standard will always fix your commas at push but I disabled it for markdown.
fuxingloh
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
Add new getNetworkInfo rpc