Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getConnectionCount rpc #176

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Add getConnectionCount rpc #176

merged 3 commits into from
Apr 30, 2021

Conversation

jingyi2811
Copy link
Contributor

/kind feature

Add new getConnectionCount rpc

@netlify
Copy link

netlify bot commented Apr 30, 2021

Deploy preview for jellyfish-defi ready!

Built with commit 1acabc1

https://deploy-preview-176--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 30, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.62 KB (+0.57% 🔺) 373 ms (+0.57% 🔺) 164 ms (+6.36% 🔺) 536 ms

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #176 (6332431) into main (79309a8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   95.48%   95.50%   +0.02%     
==========================================
  Files          54       55       +1     
  Lines        1152     1158       +6     
  Branches      138      138              
==========================================
+ Hits         1100     1106       +6     
  Misses         50       50              
  Partials        2        2              
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/net.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79309a8...6332431. Read the comment docs.

Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to https://github.com/DeFiCh/jellyfish/pull/162/files PR, when you add a new category you need to update sidebar else it will not be indexed:

https://deploy-preview-176--jellyfish-defi.netlify.app/docs

@fuxingloh fuxingloh merged commit 8a604fd into main Apr 30, 2021
@fuxingloh fuxingloh deleted the jimmy/rpc-getconnectioncount branch April 30, 2021 10:10
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants