account.listaccounts, account.getaccount, account.gettokenbalances, account.listaccounthistory #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count-gettokenbalances-listaccounthistory
…count-gettokenbalances-listaccounthistory
size-limit report 📦
|
|
Deploy preview for jellyfish-defi ready! Built with commit ba53570 |
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 95.45% 95.48% +0.03%
==========================================
Files 53 55 +2
Lines 1122 1174 +52
Branches 136 149 +13
==========================================
+ Hits 1071 1121 +50
- Misses 49 50 +1
- Partials 2 3 +1
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
Apr 29, 2021
Comment on lines
+55
to
+59
| await container.call('createtoken', [metadata]) | ||
| await container.generate(25) | ||
|
|
||
| await container.call('minttokens', [`${amount.toString()}@${symbol}`]) | ||
| await container.generate(25) |
There was a problem hiding this comment.
related to this DeFiCh/ain#346 that you reported, thanks!
fuxingloh
reviewed
Apr 29, 2021
…accounts as a func(), rpc: use optional params instead of defaut to fix coverage issue
fuxingloh
approved these changes
Apr 30, 2021
fuxingloh
deleted the
canonbrother/rpc-accounts-listaccounts-getaccount-gettokenbalances-listaccounthistory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Implemented type for RPC: #48