Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): Add tests for dusd burn attribute keys. #1603

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

surangap
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #DeFiCh/ain#1357

Additional comments?:

@surangap surangap marked this pull request as ready for review June 30, 2022 10:39
@codeclimate
Copy link

codeclimate bot commented Jun 30, 2022

Code Climate has analyzed commit c2b9c27 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit c2b9c27
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/62bd7d5148b91900086b116d
😎 Deploy Preview https://deploy-preview-1603--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1603 (c2b9c27) into main (442676a) will increase coverage by 2.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
+ Coverage   91.56%   93.73%   +2.17%     
==========================================
  Files         360      360              
  Lines       10346    10349       +3     
  Branches     1285     1286       +1     
==========================================
+ Hits         9473     9701     +228     
+ Misses        823      618     -205     
+ Partials       50       30      -20     
Impacted Files Coverage Δ
...pps/whale-api/src/module.api/masternode.service.ts 66.66% <0.00%> (-27.28%) ⬇️
apps/whale-api/src/module.api/subsidy.ts 66.66% <0.00%> (-25.00%) ⬇️
packages/jellyfish-transaction/src/script/data.ts 69.38% <0.00%> (-12.25%) ⬇️
packages/whale-api-client/src/api/address.ts 77.77% <0.00%> (-11.12%) ⬇️
.../whale-api/src/module.api/masternode.controller.ts 93.33% <0.00%> (-6.67%) ⬇️
...ages/jellyfish-api-core/src/category/masternode.ts 95.45% <0.00%> (-4.55%) ⬇️
packages/jellyfish-api-core/src/category/wallet.ts 97.70% <0.00%> (-2.30%) ⬇️
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <0.00%> (ø)
...es/jellyfish-api-core/src/category/icxorderbook.ts 95.23% <0.00%> (ø)
...s/legacy-api/src/controllers/PoolPairController.ts 85.71% <0.00%> (+1.19%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442676a...c2b9c27. Read the comment docs.

@canonbrother
Copy link
Contributor

canonbrother commented Jun 30, 2022

is extract out the test to /mn/setGov.dfip2206a.test.ts better??
btw im doing this way... LOL
https://github.com/JellyfishSDK/jellyfish/blob/fd5a3c30b362044506544e6d3ddfe0518c22866f/packages/jellyfish-api-core/__tests__/category/masternode/setGov.dfip2206f.test.ts

UPDATE: just read the test.. hmm... it makes sense as well on setGov.test.ts for just testing the "param" rather than testing the whole behaviour since that has been tested on payback section

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit 6e30e87

  • ghcr.io/jellyfishsdk/legacy-api:pr-1603
  • ghcr.io/jellyfishsdk/ocean-api:pr-1603
  • ghcr.io/jellyfishsdk/playground-api:pr-1603
  • ghcr.io/jellyfishsdk/status-api:pr-1603
  • ghcr.io/jellyfishsdk/whale-api:pr-1603

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:6e30e8708327348d5c6a6e6a3edf5260c8bcd681
  • ghcr.io/jellyfishsdk/ocean-api:6e30e8708327348d5c6a6e6a3edf5260c8bcd681
  • ghcr.io/jellyfishsdk/playground-api:6e30e8708327348d5c6a6e6a3edf5260c8bcd681
  • ghcr.io/jellyfishsdk/status-api:6e30e8708327348d5c6a6e6a3edf5260c8bcd681
  • ghcr.io/jellyfishsdk/whale-api:6e30e8708327348d5c6a6e6a3edf5260c8bcd681

@fuxingloh fuxingloh merged commit 273c8ef into main Jul 1, 2022
@fuxingloh fuxingloh deleted the surangap/direct-dusd-burn-attributes branch July 1, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants