-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): Asymmetric pool swap fee #1577
Conversation
Code Climate has analyzed commit d11579a and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
+ Coverage 92.55% 93.79% +1.24%
==========================================
Files 360 360
Lines 10349 10349
Branches 1288 1288
==========================================
+ Hits 9578 9707 +129
+ Misses 738 616 -122
+ Partials 33 26 -7
Continue to review full report at Codecov.
|
Docker build preview for jellyfish/apps is ready! Built with commit 225f11a
You can also get an immutable image with the commit hash
|
packages/jellyfish-api-core/__tests__/category/masternode/setGov.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/poolpair/poolswap.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/poolpair/poolswap.test.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/containers/RegTestContainer/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heyy.. question...
what's the diff of
[`v0/poolpairs/${ppTokenID}/token_a_fee_pct`]: '0.05'
with
[`v0/poolpairs/${ppTokenID}/token_a_fee_direction`]: 'both'
??
|
hmm.. feels like |
…1577) * Update the ain image * Update to master ain image * Added tests for fee direction set attribute * Test getPoolPair with fee direction * Added pool swap tests for asymmetric fee directions * Updated with fort canning spring height, descriptions and typos * Added a common function to pool swap * Remove code duplications
What this PR does / why we need it:
DeFiCh/ain#1354
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: